Posts made by roar

One reason is history accuracy. If you test on H1 open-only, the bot can't open a trade at 02:13 -> that trade will be opened at 03:00. Closing trades will have the same problem.

Another reason is that some block still uses "current" timeframe

@zackry Oh, yes thats mql5 there.

OrderLots() should work for mql4:
https://docs.mql4.com/trading/orderlots

It seems OrderStopLoss() is actually a level, not price fraction.
This line calculates the 1:1 level:
OrderOpenPrice()+(OrderOpenPrice()-OrderStopLoss())*1
1:2 level:
OrderOpenPrice()+(OrderOpenPrice()-OrderStopLoss())*2

Now it works with the text object. I don't really know how the price label works.

@zackry
The Price section, replace Candle with Value, and then select text(code input)

My approach:
When buying, select the order with loop block, then use OrderOpenPrice()+OrderStopLoss() functions to calculate the 1:1 level.
1:2 level would be OrderOpenPrice()+OrderStopLoss() * 2 and so on...
Bonus: no pip values, universal symbol compatibility

You can just copy-paste these blocks after your buy: https://fxdreema.com/shared/2jZ5X59Qd
I'm getting an error though, not sure if it is just my demo account

@zackry
I see. Well, at that point we already know the open - SL difference, lets just use that... a sec

@zackry
What is the plan here, again? Do you need a horizontal level or text? If level, how should it be calculated?

@zackry Yes, it definitely will cause problems with JPY. This is why I try to avoid pip values altogether.

Anyway, when you get it working on EURUSD, you can generalize the pips with the function MarketInfo(Symbol(), MODE_TICKSIZE)). I don't exactly know how to do it, but I think this is what the custom indi uses.
https://docs.mql4.com/constants/environment_state/marketinfoconstants

@zackry

See the "adjust", now the pips is raw price. For example, 20 -> 0.0020

@daedalus
Total size will not check any levels, so it is not very accurate method.
I think it is best to use that simple HH-LL comparison, it should work:
https://fxdreema.com/shared/lfV7BQdD

@zackry said in Getting values from other Indicators:

will it be possible to use other indicators entirely into the project like this so that we don't have to give the indicator along with the EA when giving the ea to someone?

Yes. The functions utilized (MarketInfo(), MathMax(), AccountInfoDouble(), etc...) are just reqular mql4 code, nothing is "tied" to the indicator

@zackry said in Getting values from other Indicators:

@roar can you please take a look at this , if its the right way to put the Risk to reward ratios? because some thing is wrong

https://fxdreema.com/shared/sSdL4sk9b

i am trying to put price labels at 1:1 1:2 1:3

I think you must first convert the SL pips to a raw price number, even though you selected "as price fraction".
The EA is now trying to calculate the final level (ask price + SL) as something like 1.1123 + 20 = 21.1123

@zackry
https://fxdreema.com/shared/UprSbpyKd
I got it printing some values.
We were missing the pip_value calculation, so that was always the default 0 -> EA crashes trying to divide by 0

I added the pip_value to the upper "modify variables", so the value is updated before used in the division.
The original EA author uses pip_value and tick_value to differentiate between symbol types. I think the "pip" is not correct scale in our design, try dividing it by 10 at some point...

Btw, you shouldn't use many comment blocks simultaneously, because the text will be overlapped

I think this animal can calculate the retracement for you:
https://fxdreema.com/shared/p08DyCEKb

It's just a rough example, sorry I'm in bit of a hurry

@zackry

Its here:

The rest is just sherlock work

@zackry

It points to the modify variables block, section 5:

SL_pips or pip_value has been set to zero, that must be fixed. Check your constant values

@zackry
When trying to backtest, it reports an error with our math:

Lets check that line from mq4

@zackry
I don't know much about the button mechanics. But in any case, there is no need to draw the same button On Tick, again and again... You can put the draw button in the On Init tab, so they are drawn at the beginning and stay there.

Yes, a numeric value would also work in the comment block. The default setting "Text" would not work, though.

Text (code input) is a universal setting, in the field you can right-click variables, just write the same variables, use mql4 functions, anything

@zackry Well there is no way to know it, really

You are learning this super fast, it took me literally years

@zackry Such an advanced project will need some troubleshooting at some point.
Use the comment block and visual backtesting to figure out what the EA is thinking

@zackry
You can't modify constants (the brown ones) in the "modify variables" block. Simply put the correct values in the constants list: